feat(fdc): Data Connect Bulk Import #2905
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the previously added DataConnect CRUD helper methods (`insert`, `insertMany`, `upsert`, `upsertMany`) based on feedback. The core implementation logic (input validation, data serialization using `objectToString`, GraphQL mutation string construction, and calling `executeGraphql`) has been moved from the `DataConnect` class (`data-connect.ts`) to the `DataConnectApiClient` class (`data-connect-api-client-internal.ts`). The methods in the `DataConnect` class now act as simple pass-through delegates to the corresponding methods on the internal client instance. Unit tests have been updated accordingly: - Tests in `index.spec.ts` now verify the delegation from `DataConnect` to `DataConnectApiClient`. - New tests have been added to `data-connect-api-client-internal.spec.ts` to cover the implementation details within `DataConnectApiClient`. This change improves separation of concerns, keeping the public API surface (`DataConnect`) clean and concentrating the implementation details within the internal client.
lahirumaramba
changed the title
lahirumaramba
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/unit/data-connect/data-connect-api-client-internal.spec.ts
Dismissed
Show dismissed
Hide dismissed
maneesht
reviewed
May 7, 2025
| * Handles nested objects, arrays, strings, numbers, and booleans. | ||
| * Ensures strings are properly escaped. | ||
| */ | ||
| private objectToString(data: any): string { |
There was a problem hiding this comment.
Should this just be unknown?
| }); | ||
|
|
||
| if (kvPairs.length === 0) { | ||
| return '{}'; // Represent an object with no defined properties as {} |
There was a problem hiding this comment.
Hmm, I'm not sure there's a case for when this would happen
| if (validator.isArray(data)) { | ||
| throw new FirebaseDataConnectError( | ||
| DATA_CONNECT_ERROR_CODE_MAPPING.INVALID_ARGUMENT, | ||
| '`data` must be an object, not an array, for single insert.'); |
There was a problem hiding this comment.
I wonder if we should help even more and say for arrays, please use "insertMany"
| extras: [1, undefined, 'hello', undefined, { a: 1, b: undefined }] | ||
| }; | ||
|
|
||
| const tableNames = ['movie', 'Movie', 'MOVIE', 'toybox', 'toyBox', 'ToyBox', 'TOYBOX']; |
There was a problem hiding this comment.
Can we also add a case for mOvIE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new API interfaces for
insert,insertMany,upsert,upsertManyoperations.